feat: add trace_metric_byte to DataCategory enum#5626
Merged
romtsn merged 6 commits intoJul 3, 2026
Conversation
tsushanth
requested review from
0xadam-brown,
adinauer,
markushi,
romtsn and
runningcode
as code owners
runningcode
approved these changes
Jun 25, 2026
runningcode
left a comment
runningcode
left a comment
Contributor
There was a problem hiding this comment.
Looks good. Can you run API dump to re-generate the api? https://github.com/getsentry/sentry-java/blob/main/CONTRIBUTING.md#binary-compatibility-validation
Contributor
Author
|
Done — added |
… discarded Mirrors the LogByte pattern: records byte-level data category alongside the item-level one when trace metrics are dropped by beforeSendMetrics, queue overflow, or envelope discard. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
romtsn
force-pushed
the
fix-trace-metric-byte-data-category
branch
from
2eac35d to
5dc77d0
Compare
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
adinauer
approved these changes
Jul 3, 2026
adinauer
left a comment
adinauer
left a comment
Member
There was a problem hiding this comment.
Thanks for the contribution! Changes look good to me but while reviewing I noticed some gaps in both this and the pre-existing log_byte handling:
EventProcessordiscards aren't tracked- Rate limiter doesn't apply the
*_bytecategories to the respective feature
I'll open PRs to address these.
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5618
The
DataCategoryenum was missing atrace_metric_byteentry, which is defined in the Sentry SDK developer docs as a byte-count category for trace metrics. Without it, client outcome reporting cannot correctly attribute discarded trace metric bytes, so those losses go untracked.This change adds
TraceMetricByte("trace_metric_byte")toDataCategory, following the same pattern asTraceMetric,LogItem,LogByte, and other categories. The existingDataCategory.valueOf(StringUtils.camelCase(catItem))path inRateLimiterwill automatically resolve"trace_metric_byte"to the new enum value when it appears in rate-limit response headers.